Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eachOfLimit with limit < 1 should error #1249

Closed
megawac opened this issue Jul 21, 2016 · 3 comments
Closed

eachOfLimit with limit < 1 should error #1249

megawac opened this issue Jul 21, 2016 · 3 comments

Comments

@megawac
Copy link
Collaborator

megawac commented Jul 21, 2016

Currently instantly resolves. I think this should be a case we throw an error in.

@aearly
Copy link
Collaborator

aearly commented Jul 30, 2016

I agree, a limit of 0 or less would certainly be a programmer error.

It's weird that we have a test for the old behavior. I'm not sure how limit 0 would be useful to anyone.

@vkstack
Copy link

vkstack commented Aug 22, 2016

Definitely throw an error.

@mikael-entefy
Copy link

Please also throw on undefined.
That would have made finding my async.eachLimit(list, config.propWithType, fn) bug way easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants