Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async.race() method #1018

Closed
wants to merge 1 commit into from
Closed

async.race() method #1018

wants to merge 1 commit into from

Conversation

jorgebay
Copy link
Contributor

@jorgebay jorgebay commented Feb 1, 2016

Based on the discussion from #568 .
Contains mocha-based tests and readme update.

async.race = function (tasks, callback) {
callback = _once(callback || noop);
if (!_isArray(tasks)) {
return callback(new TypeError('First argument to waterfall must be an array of functions'));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, change waterfall to race

@megawac
Copy link
Collaborator

megawac commented Feb 2, 2016

👍

@aearly
Copy link
Collaborator

aearly commented Feb 2, 2016

@megawac Should we merge this now, or wait until the modularization is complete? (That branch is almost ready to be merged, just some package questions remaining).

@megawac
Copy link
Collaborator

megawac commented Feb 3, 2016

Either way is fine, I can rebase/cherry-pick any commits onto the
modularizations branch

On Tue, Feb 2, 2016 at 5:57 PM, Alex Early notifications@github.com wrote:

@megawac https://github.com/megawac Should we merge this now, or wait
until the modularization is complete? (That branch is almost ready to be
merged, just some package questions remaining).


Reply to this email directly or view it on GitHub
#1018 (comment).

@jorgebay
Copy link
Contributor Author

jorgebay commented Feb 3, 2016

@aearly @megawac I could send a new pull request against the modularization branch and close this one, what do you think?

@aearly
Copy link
Collaborator

aearly commented Feb 3, 2016

That would be really helpful.

@jorgebay jorgebay closed this Feb 3, 2016
@aearly
Copy link
Collaborator

aearly commented Feb 24, 2016

Modularization is now on master, so no weird branch to consider now!

@jorgebay
Copy link
Contributor Author

Thanks for the heads up, I will submit a new pr soon.

@megawac
Copy link
Collaborator

megawac commented Feb 24, 2016

Cool @jorgebay. By the way, it might make sense to implement this via async.some as you can accomplish the same result with some

@aearly aearly mentioned this pull request Feb 24, 2016
@aearly
Copy link
Collaborator

aearly commented Feb 24, 2016

Yeah, but heads up, we also want to change the arguments for some and family to take an error in the callback. #118

@jorgebay jorgebay mentioned this pull request Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants