Fast path eachOf array case #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megawac
force-pushed
the
fast-path-eachOf
branch
from
1589e70
to
aa5673e
Compare
|
Fine by me. Might be good to document this decision somewhere that this was a case that was optimized for. |
|
LGTM. I remember we lost some performance in the pure parallel case when we ewnt with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#847 was a valuable change to the code base in which we definetely cleaned things up.
In this PR I want to add a special case, where we consider the array case separate from the generic case. I think this is important as I believe the parallel cases of
each,eachOf,map,filter, etc when provided arrays are one of the hottest paths in the library. Therefore, I have decided to optimize parallel array processing for all methods which useeachOffor the array case and defer to theeachOfLimitimplementation for objects and iterators.On my run of the relevant benchmarks, the suite ran 27.4% faster
/cc @aearly @charlierudolph