Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter, reject, detect, some, every with error #774

Closed
wants to merge 14 commits into from
Closed

filter, reject, detect, some, every with error #774

wants to merge 14 commits into from

Conversation

charlierudolph
Copy link
Contributor

@aearly

fixes #118

@aearly
Copy link
Collaborator

aearly commented Jun 2, 2015

Thanks for this. It's going to be on hold until we're putting together async 2.0, though.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.21%) to 95.07% when pulling e6002e8 on charlierudolph:cr-withError into ba7c7ba on caolan:master.

@charlierudolph
Copy link
Contributor Author

Sounds good. Let me know if this ever needs any updates

@charlierudolph charlierudolph changed the title filter, reject, some, every with error filter, reject, detect, some, every with error Jun 2, 2015
@charlierudolph
Copy link
Contributor Author

Updated this to include detect and fixes to the README.md

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 94.93% when pulling 569f928 on charlierudolph:cr-withError into ba7c7ba on caolan:master.

@megawac
Copy link
Collaborator

megawac commented Jun 24, 2015

Definitely 👍 on this

charlierudolph added 2 commits June 24, 2015 09:42
# Conflicts:
#	lib/async.js
# Conflicts:
#	test/test-async.js
@aearly aearly added this to the 2.0 milestone Jun 29, 2015
charlierudolph added 2 commits July 16, 2015 13:36
@davidlondono
Copy link

+1

@charlierudolph
Copy link
Contributor Author

@aearly @megawac any update? I'd like to see this either merged into master or a dedicated 2.0 branch instead of leaving this sitting around.

@megawac
Copy link
Collaborator

megawac commented Sep 9, 2015

👍 I want to get one more 1.4.3 release out before we start a 2.0 branch tho (cause itll be a pain to keep rebasing the two)

@aearly
Copy link
Collaborator

aearly commented Sep 9, 2015

Sorry, been too busy recently to have free cycles for async :(

@charlierudolph
Copy link
Contributor Author

Why do you even need a 2.0 branch? As long as you are following semantic versioning whats wrong with introducing a breaking change?

@aearly
Copy link
Collaborator

aearly commented Sep 16, 2015

It's nicer for people downstream to release a batch of breaking changes all at once, rather than one at a time. It's less work for people to have to check for breaking changes in their code at fewer times throughout the year.

charlierudolph added 2 commits February 16, 2016 09:15
@charlierudolph
Copy link
Contributor Author

@aearly @megawac any update this on this?

@megawac
Copy link
Collaborator

megawac commented Feb 16, 2016

Still definitely 👍 but we're in the process of moving into a modular setup for a major version bump (#996, https://github.com/caolan/async/tree/modularization). If you want to reopen against that branch we'll get it in quickly, otherwise we'll pull in when where ready to merge that branch with master

@aearly
Copy link
Collaborator

aearly commented Feb 16, 2016

Closed via #1028!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow every and filter callbacks to receive errors as first argument
5 participants