fix: make TabButton aria compliant as a button #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows using the keyboard to select tabs by pressing the Tab key to switch between elements on the page, and then pressing "enter" or space " " to select the highlighted tab. Signed-off-by: Christian Stewart <christian@aperture.us>
Make the close button on TabButton a button instead of a div. It looks identical and is aria compliant as a button, supporting screen readers and keyboard navigation with tab to select and enter or space to click. Note that a event handler for onCloseKeyDown was added to stop event propagation when pressing enter or space, so that the button's normal onClick logic is called, and the keyboard event does not propagate to the TabButton keyboard event handler. Allows using the keyboard to select the tab close button by pressing the Tab key to switch between elements on the page, and then pressing "enter" or space " " to select the highlighted button. Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
force-pushed
the
tab-button-aria
branch
from
fa4c7bb
to
7cf890f
Compare
|
@nealus Fixed aria-compliance for TabButton and the close button on TabButton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using the keyboard to select tabs by pressing the Tab key to switch between elements on the page, and then pressing "enter" or space " " to select the highlighted tab.