fix: [1406] Fixes issue with insertBefore and comment reference node

capricorn86 · Apr 13, 2024 · 676c634 · 676c634
1 parent c29f36c
commit 676c634
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/packages/happy-dom/src/nodes/element/ElementUtility.ts b/packages/happy-dom/src/nodes/element/ElementUtility.ts
@@ -171,6 +171,13 @@ export default class ElementUtility {
 						parentNodeChildren.splice(index, 1);
 					}
 				}
+				const parentChildNodes = (<Element>ancestorNode)[PropertySymbol.childNodes];
+				if (parentChildNodes) {
+					const index = parentChildNodes.indexOf(newNode);
+					if (index !== -1) {
+						parentChildNodes.splice(index, 1);
+					}
+				}
 			}
 
 			const ancestorNodeChildren = <HTMLCollection<HTMLElement>>(

diff --git a/packages/happy-dom/test/nodes/element/Element.test.ts b/packages/happy-dom/test/nodes/element/Element.test.ts
@@ -1235,6 +1235,18 @@ describe('Element', () => {
 			expect(element.children['div'] === div).toBe(true);
 			expect(element.children['span2'] === span2).toBe(true);
 		});
+
+		it('Inserts correctly with comment reference node', () => {
+			const container = document.createElement('div');
+			const child = document.createElement('p');
+			child.textContent = 'A';
+			container.appendChild(child);
+			const comment = document.createComment('');
+			container.appendChild(comment);
+			container.insertBefore(child, comment);
+			const elements = container.querySelectorAll('p');
+			expect(elements.length).toBe(1);
+		});
 	});
 
 	describe('get previousElementSibling()', () => {