Merge pull request #854 from danielrentz/task/853-Range-cloneContents

#853@minor: Fix method Range.cloneContents
capricorn86 · Apr 13, 2023 · e697ebc · e697ebc
2 parents 9574b58 + cfa7c0b
commit e697ebc
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/happy-dom/src/range/Range.ts b/packages/happy-dom/src/range/Range.ts
@@ -79,8 +79,6 @@ export default class Range {
 			const length = NodeUtility.getNodeLength(this._start.node);
 			if (this._start.offset > length) {
 				this._start.offset = length;
-			} else if (length === 0) {
-				this._start.offset = 0;
 			}
 		}
 
@@ -98,8 +96,6 @@ export default class Range {
 			const length = NodeUtility.getNodeLength(this._end.node);
 			if (this._end.offset > length) {
 				this._end.offset = length;
-			} else if (length === 0) {
-				this._end.offset = 0;
 			}
 		}
 
@@ -343,8 +339,8 @@ export default class Range {
 			fragment.appendChild(clone);
 
 			const subRange = new Range();
-			subRange._start.node = this._end.node;
-			subRange._start.offset = endOffset;
+			subRange._start.node = this._start.node;
+			subRange._start.offset = startOffset;
 			subRange._end.node = firstPartialContainedChild;
 			subRange._end.offset = NodeUtility.getNodeLength(firstPartialContainedChild);
 

diff --git a/packages/happy-dom/test/range/Range.test.ts b/packages/happy-dom/test/range/Range.test.ts
@@ -291,6 +291,22 @@ describe('Range', () => {
 
 			expect(document.body.innerHTML).toBe('ample: <i>italic</i> and <b>bol</b>');
 		});
+
+		// Fix for https://github.com/capricorn86/happy-dom/issues/853.
+		it('Clones multiple child elements inside a paragraph.', () => {
+			const paragraph = document.createElement('p');
+
+			paragraph.innerHTML = 'Example: <i>italic</i> and <b>bold</b>';
+
+			range.setStart(paragraph.querySelector('i').firstChild, 2);
+			range.setEnd(paragraph.querySelector('b').firstChild, 3);
+
+			const documentFragment = range.cloneContents();
+
+			document.body.appendChild(documentFragment);
+
+			expect(document.body.innerHTML).toBe('<i>alic</i> and <b>bol</b>');
+		});
 	});
 
 	describe('cloneRange()', () => {