#1010@patch: Check HTMLButtonElementNamedNodeMap removedItem is defined before accessing properties #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capricorn86
approved these changes
Aug 4, 2023
capricorn86
force-pushed
the
bug/1010-button-disable-false
branch
from
8c4d1ad
to
e62d2fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1010
Check that
removedItemexists before trying to access properties inHTMLButtonElementNamedNodeMap. Same solution as exists in the inherited HTMLElementNamedNodeMap class; https://github.com/capricorn86/happy-dom/blob/master/packages/happy-dom/src/nodes/html-element/HTMLElementNamedNodeMap.ts#L32.Also added another test for this specific case in #1010