Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1097@patch: Implements Symbol.toStringTag on EventTarget and AbortSignal. #1098

Merged

Conversation

Afsoon
Copy link
Contributor

@Afsoon Afsoon commented Sep 26, 2023

Fixes #1097

@Afsoon Afsoon force-pushed the task/1097-implements-symbol-toStringTag branch from e7f4c39 to 5e79688 Compare September 27, 2023 06:12
@Afsoon Afsoon force-pushed the task/1097-implements-symbol-toStringTag branch from 5e79688 to bd59cb6 Compare September 27, 2023 06:16
@Afsoon
Copy link
Contributor Author

Afsoon commented Sep 27, 2023

~~@capricorn86 any guidance on why is failing the test? In my local isn't throwing an error, even after delete the .turbo folder. ~~ So I assume that UncaughtExceptionObserver.test it's a flaky test, no?

Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🌟

@capricorn86
Copy link
Owner

~~@capricorn86 any guidance on why is failing the test? In my local isn't throwing an error, even after delete the .turbo folder. ~~ So I assume that UncaughtExceptionObserver.test it's a flaky test, no?

I believe it has something to do with the turborepo cache in Github. I have tried to fix it, but it seems like it is still flaky.

@capricorn86 capricorn86 merged commit c68e51a into capricorn86:master Sep 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants