feat: [#1315] Implement the getSetCookie method of Headers #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and removes logic for splitting cookie string
capricorn86
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Thank you for contributing @ushiboy! 🌟
I think that is safer to just add support for multiple values to Headers instead of splitting the cookie string, so I changed the logic in Headers and removed the utility used for splitting.
I hope you are fine with the solution 🙂
|
Thanks @capricorn86 I agree that changing the data structure would be a more appropriate approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1315
Implemented the getSetCookie method of Headers.