fix: [#1363] Fix bug with missing fallback value #1381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1363
Custom properties without fallback values can be converted to custom properties with fallback values (using
SINGLE_CSS_VARIABLE_REGEXP
).e.g.
var(--known)
--known
.var(--unknown, var(--known)
var(--unknown, known-color)
by resolving the--known
value.var(--unknown, var(--unknown, var(--known)))
var(--unknown, var(--unknown, known-color))
by resolving the value of--known
.After converting to a custom property for which a fallback value exists, the value can be found using a regular expression that handles the custom property in this case (using
CSS_VARIABLE_REGEXP
).