Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#774@patch: Add visibility state to Document. #775

Merged
merged 1 commit into from Feb 24, 2023
Merged

#774@patch: Add visibility state to Document. #775

merged 1 commit into from Feb 24, 2023

Conversation

CSchulz
Copy link
Contributor

@CSchulz CSchulz commented Feb 22, 2023

fixes #774.

@CSchulz
Copy link
Contributor Author

CSchulz commented Feb 22, 2023

I have no clue why the tests are failing 😅 Locally everything works for me.

capricorn86
capricorn86 requested changes Feb 23, 2023
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! 🌟 Just a minor thing (which causes the unit tests to fail).

packages/happy-dom/src/nodes/document/Document.ts Outdated Show resolved Hide resolved
@capricorn86 capricorn86 merged commit 4ac24eb into capricorn86:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capricorn86 capricorn86 capricorn86 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

document.visibilityState is undefined
2 participants
@CSchulz @capricorn86