Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#519@patch: Fixes XMLParser Bug. #782

Merged
merged 6 commits into from Feb 24, 2023
Merged

#519@patch: Fixes XMLParser Bug. #782

merged 6 commits into from Feb 24, 2023

Conversation

Mas0nShi
Copy link
Contributor

@Mas0nShi Mas0nShi commented Feb 23, 2023 •
edited

Fix #519

e.g.

const window = new Window(), document = window.document;

const html = `<html>
<!--[if lt IE 9]>
    <script>window.location = 'browser.htm';</script>
<![endif]-->
</html>`;
document.write(html);

const source = new window.XMLSerializer().serializeToString(document);
console.assert(source === html);
console.log(window.location);

// Location {
// 	href: 'about:blank',
// 		origin: 'null',
// 		protocol: 'about:',
// 		username: '',
// 		password: '',
// 		host: '',
// 		hostname: '',
// 		port: '',
// 		pathname: 'blank',
// 		search: '',
// 		searchParams: URLSearchParams {},
// 	hash: ''
// }

@Mas0nShi Mas0nShi force-pushed the 519-fixes-parse-conditional-comments branch from 97e95e9 to aabf229 Compare February 23, 2023 09:42
@Mas0nShi Mas0nShi force-pushed the 519-fixes-parse-conditional-comments branch from 96999a8 to 7a9c2eb Compare February 24, 2023 11:49
capricorn86
capricorn86 reviewed Feb 24, 2023
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🌟

@capricorn86 capricorn86 merged commit 2cb3f15 into capricorn86:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capricorn86 capricorn86 capricorn86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XMLParser Error
2 participants
@Mas0nShi @capricorn86