Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#805@patch: Improve event listener. #806

Merged
merged 4 commits into from
Apr 19, 2023

Conversation

btea
Copy link
Contributor

@btea btea commented Mar 5, 2023

fix #805

@btea btea requested a review from capricorn86 as a code owner March 5, 2023 04:23
capricorn86
capricorn86 previously approved these changes Apr 4, 2023
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🙂

@capricorn86
Copy link
Owner

It seems like the unit test is failing. Not sure why 🤷‍♂️

@btea
Copy link
Contributor Author

btea commented Apr 5, 2023

I have fixed it 😀

@btea
Copy link
Contributor Author

btea commented Apr 19, 2023

@capricorn86 I've fixed the test issue and it looks ok so far, can you review it again?

@capricorn86 capricorn86 merged commit 73b4b82 into capricorn86:master Apr 19, 2023
1 check passed
@capricorn86
Copy link
Owner

@capricorn86 I've fixed the test issue and it looks ok so far, can you review it again?

Looks good! 👍

@btea btea deleted the task/805-improve-event-listener branch April 19, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Dispatch - handleEvent undefined
2 participants