Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code over #823

Closed
wants to merge 2 commits into from
Closed

code over #823

wants to merge 2 commits into from

Conversation

Titiksha2608
Copy link

No description provided.

capricorn86
capricorn86 requested changes Apr 4, 2023
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain why we should remove the commit validation? It helps people checking the commits before pushing in the code. Otherwise the build will fail instead.

@capricorn86
Copy link
Owner

If you have a problem contributing, you can check out this guide:
https://github.com/capricorn86/happy-dom/blob/master/docs/contributing.md

Or just reach out and I can explain how it works.

@ekwoka
Copy link
Contributor

ekwoka commented Apr 6, 2023

Also, if really needed, for some reason, the commit can be done with --no-validation to bypass the commit hooks

@capricorn86
Copy link
Owner

I will close this PR based on the answer in the comments.

@capricorn86 capricorn86 closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capricorn86 capricorn86 capricorn86 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Titiksha2608 @capricorn86 @ekwoka