Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#818@patch: Convert special characters to HTML entities. #824

Merged
merged 7 commits into from
Apr 12, 2023
Merged

#818@patch: Convert special characters to HTML entities. #824

merged 7 commits into from
Apr 12, 2023

Conversation

btea
Copy link
Contributor

@btea btea commented Mar 12, 2023

fix #818

@btea btea requested a review from capricorn86 as a code owner March 12, 2023 05:31
capricorn86
capricorn86 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @btea! ⭐

I made some fixes to the code, so that it follows the same style of coding as other logic in Happy DOM. I also made some improvements to performance.

@capricorn86 capricorn86 merged commit 9574b58 into capricorn86:master Apr 12, 2023
1 check passed
@btea btea deleted the task/818-convert-character branch April 13, 2023 01:02
@btea
Copy link
Contributor Author

btea commented Apr 13, 2023 •
edited

Looks great 👍

HTML_ENTITIES currently only lists a part, do we need to add other characters? reference documents

@capricorn86
Copy link
Owner

Looks great 👍

HTML_ENTITIES currently only lists a part, do we need to add other characters? reference documents

That would be good 👍😊 But I guess the most prioritized list is in?

@btea
Copy link
Contributor Author

btea commented Apr 13, 2023

If adding all of them seems like too much, it may be enough for now to add characters that are common to the keyboard, such as @, #, $. . .

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capricorn86 capricorn86 capricorn86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

happy-dom doesn't convert > to > whereas jsdom does
2 participants
@btea @capricorn86