Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#820@minor: Add SubmitEvent. #855

Merged
merged 2 commits into from
Apr 13, 2023
Merged

#820@minor: Add SubmitEvent. #855

merged 2 commits into from
Apr 13, 2023

Conversation

danielrentz
Copy link
Contributor

@danielrentz danielrentz commented Apr 13, 2023 •
edited

fix #820

  • add class SubmitEvent
  • HTMLFormElement.requestSubmit triggers a SubmitEvent
  • adapted unit tests

capricorn86
capricorn86 approved these changes Apr 13, 2023
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution! 🌟

@capricorn86 capricorn86 merged commit 5b87a3a into capricorn86:master Apr 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capricorn86 capricorn86 capricorn86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing window.SubmitEvent
2 participants
@danielrentz @capricorn86