Use CSS variables for sprite images #1020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captbaritone
commented
Oct 2, 2020
| @@ -25,9 +25,6 @@ export const imageSelectors: Selectors = { | |||
| MAIN_STOP_BUTTON_ACTIVE: [".actions #stop:active"], | |||
| MAIN_NEXT_BUTTON: [".actions #next"], | |||
| MAIN_NEXT_BUTTON_ACTIVE: [".actions #next:active"], | |||
| MAIN_EJECT_BUTTON: ["#eject"], | |||
| MAIN_EJECT_BUTTON_ACTIVE: ["#eject:active"], | |||
| MAIN_WINDOW_BACKGROUND: ["#main-window"], | |||
There was a problem hiding this comment.
Long term, this change would let us replace these ~310 lines of random looking CSS selectors with calls to useSprite in each component that uses a sprite, thus allowing the reader of the component to know how it gets styled without having to know to check this file.
captbaritone
commented
Oct 2, 2020
| | "GEN_MIDDLE_LEFT_BOTTOM" | ||
| | "GEN_MIDDLE_RIGHT" | ||
| | "GEN_MIDDLE_RIGHT_BOTTOM" | ||
| | "GEN_CLOSE_SELECTED"; |
There was a problem hiding this comment.
This is a huge list, but it's just a type. No bundle cost.
captbaritone
force-pushed
the
css-variables
branch
from
c177f5f
to
3b7a830
Compare
|
Some quite valid integration test failures here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.