Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winamp Visualizer by @x2nie #1226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

0x5066
Copy link
Contributor

@0x5066 0x5066 commented Aug 12, 2023

This is the initial work done by @x2nie and my attempt to continue the work, which unfortunately has failed.

There's a lot of things unfinished, but I didn't want to leave it on my hard drive, hence this PR.

A lot of things are missing and this is deemed incomplete.

  • Visualizer continues running when player is paused/stopped
  • Visualizer does not shift 2 pixels down when not in double size mode
  • Visualizer only exists in the Main Window, not in the Main Window shade mode and the Playlist Editor, those still use the old way.

For documentation purposes, should anyone else pick up on this, the Visualizer behaves differently in the Main Window shade mode and Playlist Editor:

  • In the MW shade mode, the visualizer is constrained to a space of 38px width and 5px height, only using the first color of the Oscilloscope. (Seems to draw a gradient based on two colors, needs more investigation)

  • In addition, it looks different, this is achieved by removing top++; in the Lines code for the Oscilloscope.

  • The Spectrum Analyzer still draws its colors, but only a select few of them, still needs investigating what colors are used exactly.

  • Peaks are still drawn, but when the Spectrum Analyzer hits the top, the peaks disappear.

  • In double size mode, the Visualizer is now only constrained to a space of 75px width and 10px height.

  • The Playlist Editor has it's own small area that's 72px in width and 16px in height, no other notable differences are present.

@netlify
Copy link

netlify bot commented Aug 12, 2023

Deploy Preview for vigorous-lalande-5190c2 ready!

Name Link
🔨 Latest commit bd43d1a
🔍 Latest deploy log https://app.netlify.com/sites/vigorous-lalande-5190c2/deploys/64d702dfcc31f90007098f9a
😎 Deploy Preview https://deploy-preview-1226--vigorous-lalande-5190c2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant