Trying some stuff with browserslist #883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 58fd75c.
This moves to using a node Buffer to hold the command bytecode which resolves a character encoding issue we were having
These values were extracted from the perl script
These get tested locally.
* Add some unimplemented methods to classes * fix test
This actually removes a bunch of edgecases/race conditions
This is the last main window component still using the HOC!
Aparently window.stop() is a thing, and ESLint/TypeScript let me do this. Sigh. A potential fix: facebook/create-react-app#1840
We had a bug where `stop()` was undefined but it fell back to the function on window which was inplicitly in the global scope. This should reduce that kind of thing.
* Fix windows filename slashes * add comment * readXml will already convert the slashes
This will make it easier to mock out these methods in tests to use Node apporaches to these problems
* Add missing config classes * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.