Update Google client initialisation to use MLP helper method #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
commented
Mar 29, 2023
treatment-service/models/storage.go
Outdated
Comment on lines
581
to
585
| googleClient, err = idtoken.NewClient( | ||
| context.Background(), | ||
| defaultCaraMLAudience, | ||
| idtoken.WithCredentialsFile(filepath), | ||
| ) |
There was a problem hiding this comment.
Will be replacing this block with the new method InitGoogleClientFromCredentialsFile introduced in caraml-dev/mlp#79 (after this gets approved and merged) which initialises a Google client a specified file path for both service AND user accounts.
deadlycoconuts
commented
Mar 29, 2023
| IgnoreStatusCodes: nil, | ||
| IgnoreStatusCodes: []int{}, |
There was a problem hiding this comment.
This change here is to address this change in behaviour of the unit tests: https://github.com/caraml-dev/xp/actions/runs/4545757610/jobs/8013518375#step:5:233
krithika369
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
@deadlycoconuts, thanks for also testing out the plugin auth behavior and handling it. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With the introduction of a helper method in MLP (caraml-dev/mlp#78) to abstract away the creation of a Google client to append ID tokens to the headers of outgoing requests, that is authenticated with service or user accounts, this PR imports the said helper method and uses it to initialise its Google client.
This ensures that all outgoing requests from the Turing API server contain ID tokens in their headers.
Which issue(s) this PR fixes:
Fixes #