fix(modal): fix JavaScript error in IE11 #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We hit babel/babel#7597 with our logic turning `NodeList` to an array, but turned out it's not needed there. Fixes carbon-design-system#2068.
|
Deploy preview for the-carbon-components ready! Built with commit 75c9327 https://deploy-preview-2183--the-carbon-components.netlify.com |
joshblack
approved these changes
Mar 22, 2019
|
I have no access to IE11. Does any designer have access to IE11? |
|
🎉 This PR is included in version 9.88.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit babel/babel#7597 with our logic turning
NodeListto an array, but turned out it's not needed there.Fixes #2068.
Changelog
Removed
NodeListto an array in modal instantiation logic.Testing / Reviewing
Testing should make sure modal is not broken. The fix to the bug can be verified by (successfully) opening modal in our dev env with IE11.