-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial drop of IdeEmptyState #168
Conversation
Deploy preview for ibm-cloud-cognitive ready! Built with commit 1c87fd2 |
I believe we already have an empty state that follows the new pattern: |
@CptPilot Indeed, but that's under experimental not our prod ready component, so I won't feel confident to consume experiemental code in CP4I production code - FYI @asfordmatt |
Yes indeed, we need our "V1" components in here as-is, so consuming teams can easily transition to using this repo. The new "V2" components are still in development and not yet ready for production use. |
…tem/ibm-cloud-paks into adding_ide-empty-state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributes to #
Another component transfer from the old unified design repo, IdeEmptyState
Changelog
Use the following command to list changes or manually list out new, changed and
removed files.
New
New ESLINT rule introduced as part of this PR, since
react/display-name
is to aggresive with implied defined components:jsx-eslint/eslint-plugin-react#597. If we are to keep this rule set to even warning, here's what we'd possibly getting:
Changed
Removed
Testing / Reviewing
N/A