Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial drop of IdeEmptyState #168

Merged
merged 10 commits into from
Oct 30, 2020
Merged

Initial drop of IdeEmptyState #168

merged 10 commits into from
Oct 30, 2020

Conversation

vladbalanescu
Copy link
Contributor

@vladbalanescu vladbalanescu commented Oct 30, 2020

Contributes to #

Another component transfer from the old unified design repo, IdeEmptyState

Changelog

Use the following command to list changes or manually list out new, changed and
removed files.

git diff --name-status $(git merge-base head master)
A       packages/cdai/src/components/IdeEmptyState/IdeEmptyState.js
A       packages/cdai/src/components/IdeEmptyState/IdeEmptyState.spec.js
A       packages/cdai/src/components/IdeEmptyState/IdeEmptyState.stories.js
A       packages/cdai/src/components/IdeEmptyState/README.md
A       packages/cdai/src/components/IdeEmptyState/_IdeEmptyState.scss
A       packages/cdai/src/components/IdeEmptyState/__snapshots__/IdeEmptyState.spec.js.snap
A       packages/cdai/src/components/IdeEmptyState/assets/api-error.lg.svg
A       packages/cdai/src/components/IdeEmptyState/assets/api-error.sm.svg
A       packages/cdai/src/components/IdeEmptyState/assets/default.lg.svg
A       packages/cdai/src/components/IdeEmptyState/assets/default.sm.svg
A       packages/cdai/src/components/IdeEmptyState/assets/deploy.lg.svg
A       packages/cdai/src/components/IdeEmptyState/assets/deploy.sm.svg
A       packages/cdai/src/components/IdeEmptyState/assets/index.js
A       packages/cdai/src/components/IdeEmptyState/assets/no-search-results.lg.svg
A       packages/cdai/src/components/IdeEmptyState/assets/no-search-results.sm.svg
A       packages/cdai/src/components/IdeEmptyState/assets/not-authorized.lg.svg
A       packages/cdai/src/components/IdeEmptyState/assets/not-authorized.sm.svg
A       packages/cdai/src/components/IdeEmptyState/index.js
A       packages/cdai/src/components/IdeEmptyState/test_assets/custom.lg.svg
A       packages/cdai/src/components/IdeEmptyState/test_assets/custom.sm.svg
M       packages/cdai/src/index.js

New

New ESLINT rule introduced as part of this PR, since react/display-name is to aggresive with implied defined components:
jsx-eslint/eslint-plugin-react#597. If we are to keep this rule set to even warning, here's what we'd possibly getting:
image (2)

Changed

  • N/A

Removed

  • N/A

Testing / Reviewing

N/A

@vladbalanescu vladbalanescu requested a review from a team as a code owner October 30, 2020 10:12
@netlify
Copy link

netlify bot commented Oct 30, 2020

Deploy preview for ibm-cloud-cognitive ready!

Built with commit 1c87fd2

https://deploy-preview-168--ibm-cloud-cognitive.netlify.app

@richardpilot
Copy link
Contributor

I believe we already have an empty state that follows the new pattern:

#159

@vladbalanescu
Copy link
Contributor Author

@CptPilot Indeed, but that's under experimental not our prod ready component, so I won't feel confident to consume experiemental code in CP4I production code - FYI @asfordmatt

@asfordmatt
Copy link
Member

Yes indeed, we need our "V1" components in here as-is, so consuming teams can easily transition to using this repo. The new "V2" components are still in development and not yet ready for production use.

Copy link
Member

@asfordmatt asfordmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfordmatt asfordmatt merged commit f1239c8 into master Oct 30, 2020
@asfordmatt asfordmatt deleted the adding_ide-empty-state branch October 30, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants