New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/198 construction derive staking support #207

Merged

tomasBustamante merged 22 commits into master from feat/198-construction-derive-staking-support

Nov 11, 2020

Contributor

tomasBustamante commented Nov 6, 2020

Description

Endpoint /construction/derive now supports the creation of Base and Reward addresses besided the already supported Enterprise address.

Proposed Solution

The staking key and the address type are provided as optional parameters in the metadata.

The controller does some basic validation and the service does the actual construction based on the following:

Base address: if address type is 'Base' and both the public key and the staking keys are provided.
Reward address: if address type is 'Reward' (the required public key is the only needed).
Enterprise address: if address type is 'Enterprise' or no type at all (default scenario).

References

Closes #198

tomasBustamante requested a review from AlanVerbner

November 6, 2020 05:49

tomasBustamante force-pushed the feat/198-construction-derive-staking-support branch from 0d14712 to 1b122be Compare

November 6, 2020 06:51

AlanVerbner reviewed

View reviewed changes

cardano-rosetta-server/src/server/services/cardano-services.ts Outdated Show resolved Hide resolved

AlanVerbner reviewed

View reviewed changes

cardano-rosetta-server/src/server/controllers/construction-controller.ts Outdated Show resolved Hide resolved

AlanVerbner reviewed

View reviewed changes

cardano-rosetta-server/src/server/controllers/construction-controller.ts Show resolved Hide resolved

AlanVerbner reviewed

View reviewed changes

cardano-rosetta-server/src/server/utils/constants.ts Outdated Show resolved Hide resolved

AlanVerbner reviewed

View reviewed changes

cardano-rosetta-server/src/server/services/cardano-services.ts Show resolved Hide resolved

AlanVerbner reviewed

View reviewed changes

cardano-rosetta-server/src/server/services/cardano-services.ts Outdated Show resolved Hide resolved

AlanVerbner reviewed

View reviewed changes

cardano-rosetta-server/src/server/services/cardano-services.ts Show resolved Hide resolved

AlanVerbner reviewed

View reviewed changes

cardano-rosetta-server/src/server/services/cardano-services.ts Outdated Show resolved Hide resolved

AlanVerbner reviewed

View reviewed changes

cardano-rosetta-server/test/e2e/construction/construction-derive-api.test.ts Show resolved Hide resolved

tomasBustamante force-pushed the feat/198-construction-derive-staking-support branch 2 times, most recently from 4040531 to 4f1849d Compare

November 11, 2020 13:15

AlanVerbner previously approved these changes

View reviewed changes

Contributor

AlanVerbner left a comment

Lgtm

tomasBustamante added 16 commits

November 11, 2020 12:19


          feat: add staking_credential and address_type in ConstructionDeriveRe…

588a2e0

…quest

Refs #198


          refactor: move staking_credential and address_type into metadata of C…

6a290b7

…onstructionDeriveRequest

Refs #198


          feat: add invalid address type error

18ab560

Refs #198


          feat: add metadata validation in construction derive controller

fb4c1bf

staking credential and address type which are optional

Refs #198


          refactor: generatePayload parameters in construction derive tests

dd4dcc2

Refs #198


          test: construction derive with invalid staking key

53152d6

Refs #198


          refactor: exclude enum for address type in openApi

d40f8b1

Refs #198


          test: construction derive with invalid address type

692e36e

Refs #198


          test: construction derive for Base and Reward addresses

bca82ad

Refs #198


          feat: construction derive Base and Reward address support

4067e70

Refs #198


          test: construction derive validation for staking key size

14e1768

Refs #198


          test: construction derive reward address correct bech32 address

c0acdbe

Refs #198


          fix: correct address prefix for reward address creation

c00045c

Refs #198


          refactor: move UTxOAddressTypes enum to constants file

d292738

Refs #198


          refactor: rename UTxOAddressType and make Enterprise default value

71052d6

Refs #198


          refactor: add comment for staking address prefix

1d59110

Refs #198

tomasBustamante added 6 commits

November 11, 2020 12:19


          test: add comments to construction derive tests

6bbfdbf

Information to generate the base and reward addresses used for assertions

Refs #198


          refactor: use proper error for invalid staking key

d007b34

Refs #198


          test: construction derive error when no staking key for base address

f545713

Refs #198


          feat: missing staking key validation for base address generation

e38870d

Refs #198


          refactor: rename AddressType

8a1ebdb

Refs #198


          refactor: address type description in openApi

b0f88c6

Refs #198

tomasBustamante dismissed AlanVerbner’s stale review via

b0f88c6

November 11, 2020 15:24

tomasBustamante force-pushed the feat/198-construction-derive-staking-support branch from 4f1849d to b0f88c6 Compare

November 11, 2020 15:24

AlanVerbner approved these changes

View reviewed changes

Contributor

AlanVerbner left a comment

lgtm

tomasBustamante merged commit fabc859 into master

AlanVerbner pushed a commit that referenced this pull request


          feat: construction derive staking support (#207)

3e38ac6

* feat: add staking_credential and address_type in ConstructionDeriveRequest

* refactor: move staking_credential and address_type into metadata of ConstructionDeriveRequest

* feat: add invalid address type error

* feat: add metadata validation in construction derive controller

* refactor: generatePayload parameters in construction derive tests

* test: construction derive with invalid staking key

* refactor: exclude enum for address type in openApi

* test: construction derive with invalid address type

* test: construction derive for Base and Reward addresses

* feat: construction derive Base and Reward address support

* test: construction derive validation for staking key size

* test: construction derive reward address correct bech32 address

* fix: correct address prefix for reward address creation

* refactor: move UTxOAddressTypes enum to constants file

* refactor: rename UTxOAddressType and make Enterprise default value

* refactor: add comment for staking address prefix

* test: add comments to construction derive tests

* refactor: use proper error for invalid staking key

* test: construction derive error when no staking key for base address

* feat: missing staking key validation for base address generation

* refactor: rename AddressType

* refactor: address type description in openApi

Refs #198

AlanVerbner pushed a commit that referenced this pull request


          feat: construction derive staking support (#207)

64ea3e0

* feat: add staking_credential and address_type in ConstructionDeriveRequest

* refactor: move staking_credential and address_type into metadata of ConstructionDeriveRequest

* feat: add invalid address type error

* feat: add metadata validation in construction derive controller

* refactor: generatePayload parameters in construction derive tests

* test: construction derive with invalid staking key

* refactor: exclude enum for address type in openApi

* test: construction derive with invalid address type

* test: construction derive for Base and Reward addresses

* feat: construction derive Base and Reward address support

* test: construction derive validation for staking key size

* test: construction derive reward address correct bech32 address

* fix: correct address prefix for reward address creation

* refactor: move UTxOAddressTypes enum to constants file

* refactor: rename UTxOAddressType and make Enterprise default value

* refactor: add comment for staking address prefix

* test: add comments to construction derive tests

* refactor: use proper error for invalid staking key

* test: construction derive error when no staking key for base address

* feat: missing staking key validation for base address generation

* refactor: rename AddressType

* refactor: address type description in openApi

Refs #198

rhyslbw pushed a commit that referenced this pull request


          feat: construction derive staking support (#207)

b8aaf64

* feat: add staking_credential and address_type in ConstructionDeriveRequest

* refactor: move staking_credential and address_type into metadata of ConstructionDeriveRequest

* feat: add invalid address type error

* feat: add metadata validation in construction derive controller

* refactor: generatePayload parameters in construction derive tests

* test: construction derive with invalid staking key

* refactor: exclude enum for address type in openApi

* test: construction derive with invalid address type

* test: construction derive for Base and Reward addresses

* feat: construction derive Base and Reward address support

* test: construction derive validation for staking key size

* test: construction derive reward address correct bech32 address

* fix: correct address prefix for reward address creation

* refactor: move UTxOAddressTypes enum to constants file

* refactor: rename UTxOAddressType and make Enterprise default value

* refactor: add comment for staking address prefix

* test: add comments to construction derive tests

* refactor: use proper error for invalid staking key

* test: construction derive error when no staking key for base address

* feat: missing staking key validation for base address generation

* refactor: rename AddressType

* refactor: address type description in openApi

Refs #198

AlanVerbner pushed a commit that referenced this pull request


          feat: construction derive staking support (#207)

2cc2c21

* feat: add staking_credential and address_type in ConstructionDeriveRequest

* refactor: move staking_credential and address_type into metadata of ConstructionDeriveRequest

* feat: add invalid address type error

* feat: add metadata validation in construction derive controller

* refactor: generatePayload parameters in construction derive tests

* test: construction derive with invalid staking key

* refactor: exclude enum for address type in openApi

* test: construction derive with invalid address type

* test: construction derive for Base and Reward addresses

* feat: construction derive Base and Reward address support

* test: construction derive validation for staking key size

* test: construction derive reward address correct bech32 address

* fix: correct address prefix for reward address creation

* refactor: move UTxOAddressTypes enum to constants file

* refactor: rename UTxOAddressType and make Enterprise default value

* refactor: add comment for staking address prefix

* test: add comments to construction derive tests

* refactor: use proper error for invalid staking key

* test: construction derive error when no staking key for base address

* feat: missing staking key validation for base address generation

* refactor: rename AddressType

* refactor: address type description in openApi

Refs #198

AlanVerbner deleted the feat/198-construction-derive-staking-support branch

December 7, 2020 19:40

AlanVerbner pushed a commit that referenced this pull request


          feat: construction derive staking support (#207)

0d8250a

* feat: add staking_credential and address_type in ConstructionDeriveRequest

* refactor: move staking_credential and address_type into metadata of ConstructionDeriveRequest

* feat: add invalid address type error

* feat: add metadata validation in construction derive controller

* refactor: generatePayload parameters in construction derive tests

* test: construction derive with invalid staking key

* refactor: exclude enum for address type in openApi

* test: construction derive with invalid address type

* test: construction derive for Base and Reward addresses

* feat: construction derive Base and Reward address support

* test: construction derive validation for staking key size

* test: construction derive reward address correct bech32 address

* fix: correct address prefix for reward address creation

* refactor: move UTxOAddressTypes enum to constants file

* refactor: rename UTxOAddressType and make Enterprise default value

* refactor: add comment for staking address prefix

* test: add comments to construction derive tests

* refactor: use proper error for invalid staking key

* test: construction derive error when no staking key for base address

* feat: missing staking key validation for base address generation

* refactor: rename AddressType

* refactor: address type description in openApi

Refs #198

AlanVerbner pushed a commit that referenced this pull request


          feat: construction derive staking support (#207)

940c711

* feat: add staking_credential and address_type in ConstructionDeriveRequest

* refactor: move staking_credential and address_type into metadata of ConstructionDeriveRequest

* feat: add invalid address type error

* feat: add metadata validation in construction derive controller

* refactor: generatePayload parameters in construction derive tests

* test: construction derive with invalid staking key

* refactor: exclude enum for address type in openApi

* test: construction derive with invalid address type

* test: construction derive for Base and Reward addresses

* feat: construction derive Base and Reward address support

* test: construction derive validation for staking key size

* test: construction derive reward address correct bech32 address

* fix: correct address prefix for reward address creation

* refactor: move UTxOAddressTypes enum to constants file

* refactor: rename UTxOAddressType and make Enterprise default value

* refactor: add comment for staking address prefix

* test: add comments to construction derive tests

* refactor: use proper error for invalid staking key

* test: construction derive error when no staking key for base address

* feat: missing staking key validation for base address generation

* refactor: rename AddressType

* refactor: address type description in openApi

Refs #198

AlanVerbner pushed a commit that referenced this pull request


          feat: construction derive staking support (#207)

4cf5ea5

* feat: add staking_credential and address_type in ConstructionDeriveRequest

* refactor: move staking_credential and address_type into metadata of ConstructionDeriveRequest

* feat: add invalid address type error

* feat: add metadata validation in construction derive controller

* refactor: generatePayload parameters in construction derive tests

* test: construction derive with invalid staking key

* refactor: exclude enum for address type in openApi

* test: construction derive with invalid address type

* test: construction derive for Base and Reward addresses

* feat: construction derive Base and Reward address support

* test: construction derive validation for staking key size

* test: construction derive reward address correct bech32 address

* fix: correct address prefix for reward address creation

* refactor: move UTxOAddressTypes enum to constants file

* refactor: rename UTxOAddressType and make Enterprise default value

* refactor: add comment for staking address prefix

* test: add comments to construction derive tests

* refactor: use proper error for invalid staking key

* test: construction derive error when no staking key for base address

* feat: missing staking key validation for base address generation

* refactor: rename AddressType

* refactor: address type description in openApi

Refs #198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment