Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
cardil committed Mar 26, 2024
1 parent b82832b commit 0bea26a
Show file tree
Hide file tree
Showing 3 changed files with 52 additions and 2 deletions.
50 changes: 50 additions & 0 deletions pkg/output/tui/bubbletee964.go
@@ -0,0 +1,50 @@
/*
Copyright 2024 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package tui

import (
"bytes"
"io"
"log"
"os"
)

// safeguardBubbletee964 will safeguard the io.Reader by returning a new
// io.Reader that will prevent the
// https://github.com/charmbracelet/bubbletea/issues/964 issue.
//
// TODO: Remove this function once the issue is resolved.
func safeguardBubbletee964(in io.Reader) io.Reader {
if in == nil {
return nil
}
if f, ok := in.(*os.File); ok {
if st, err := f.Stat(); err == nil {
log.Fatal("unexpected: ", err)
} else {
if !st.Mode().IsRegular() {
if st.Name() != os.DevNull {
log.Println("WARN: non-regular file given as input: ",
st.Name(), " (mode: ", st.Mode(),
"). Using `nil` as input.")
}
return bytes.NewBufferString("")
}
}
}
return in
}
2 changes: 1 addition & 1 deletion pkg/output/tui/progress.go
Expand Up @@ -243,7 +243,7 @@ func (b *BubbleProgress) start() {
b.prog = progress.New(progress.WithDefaultGradient())
out := b.OutOrStdout()
b.tea = tea.NewProgram(b,
tea.WithInput(b.InOrStdin()),
tea.WithInput(safeguardBubbletee964(b.InOrStdin())),
tea.WithOutput(out),
)
b.quitChan = make(chan struct{})
Expand Down
2 changes: 1 addition & 1 deletion pkg/output/tui/spinner.go
Expand Up @@ -80,7 +80,7 @@ func (b *BubbleSpinner) start() {
)
out := b.OutOrStdout()
b.tea = tea.NewProgram(b,
tea.WithInput(b.InOrStdin()),
tea.WithInput(safeguardBubbletee964(b.InOrStdin())),
tea.WithOutput(out),
)
b.quitChan = make(chan struct{})
Expand Down

0 comments on commit 0bea26a

Please sign in to comment.