Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apparently obsolete FilterMixin metaclass #1449

Open
abbottc opened this issue Oct 11, 2021 · 3 comments
Open

Remove apparently obsolete FilterMixin metaclass #1449

abbottc opened this issue Oct 11, 2021 · 3 comments

Comments

@abbottc
Copy link
Contributor

abbottc commented Oct 11, 2021

There is a metaclass on FilterMixin that was marked to be removed in version 2.1, but still exists:

# TODO: remove metaclass in 2.1

The metaclass looks like it only serves to give a warning if the long-since deprecated name filter_fields is used.

In case this was forgotten, I just wanted to bump its removal, since subclasses of FilterMixin that need their own metaclasses must do a little bit of working around this apparently obsolete metaclass as long as it still exists.

If it wasn't forgotten but remains there intentionally, is it planned for removal at any specific later version?

@carltongibson
Copy link
Owner

Hey @abbottc -- Yes, there's a couple of these cleanups lingering i think. Would you fancy taking them on?

@abbottc
Copy link
Contributor Author

abbottc commented Oct 11, 2021

Sure I can take care of them. What else needs to be cleaned up? Or are all of them marked with a clear TODO like this one that would make them easy to search for?

@carltongibson
Copy link
Owner

A quick grep for remove suggests at least a good bunch are marked with the TODO. (Didn't spot any others, but it was a very quick grep 😀)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants