Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assertions/warnings about code deprecated in version 2.1 #1451

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Remove assertions/warnings about code deprecated in version 2.1 #1451

merged 1 commit into from
Jun 16, 2022

Conversation

abbottc
Copy link
Contributor

@abbottc abbottc commented Oct 16, 2021

No description provided.

@abbottc
Copy link
Contributor Author

abbottc commented Oct 16, 2021

Resolves issue #1449

@abbottc
Copy link
Contributor Author

abbottc commented Oct 16, 2021

Incidentally, due to this PR, the class RenameAttributesBase in django_filters/utils.py is no longer used anywhere. I didn't remove that class, assuming it may be something you want to keep for possible future use, but if you want it removed I can do that as well.

carltongibson
carltongibson approved these changes Jun 16, 2022
View reviewed changes
Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @abbottc

@carltongibson carltongibson merged commit 3dfed5d into carltongibson:main Jun 16, 2022
@mochouaaaaa
Copy link

3dfed5d#r77608630
at present, the pypi official website has appeared 22.1. This problem leads to the query not accessing the orm

Is there something wrong with my use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abbottc @mochouaaaaa @carltongibson