-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update german Translation and init inlang Config #1555
Conversation
Oh wow, sorry for the video quality. I need to increase the recording settings |
HI @jannesblobel this looks interesting. Thanks. I'm looking to do an update in time for Django 4.2 so timely. I haven't heard of this tool before... 👀 |
Hi @jannesblobel — thanks for this! I've added django-filter to Weblate https://hosted.weblate.org/projects/django-filter/django-filter/ — we're hoping to move Django to this, so I'd rather use the same tools if possible. I've updated the message files too, so if you wanted to contribute your translations there, that would be amazing! I will close this PR though. |
@carltongibson , It is interesting to see how many Django projects use Weblate. Is there a specific reason for this movement? PS: The German translation should have been added/suggested via Weblate. :) |
Hi @jannesblobel -- there are two topics: updating the translations, and then the tool for doing that. It's been on the agenda to look at moving Django's translations to Weblate for a while -- there's been an amount of discussion of the best tool -- and when looking at the new release for django-filter it's a good opportunity to use it too. |
Thank you for this insides. I would be very interested to know each tool's pros and cons. Can you link the discussion/issue for me? :) |
Hi,
Changes
I saw your german translation was broken. To make it easier for me to contribute to your translation, I added the tool inlang/inlang. I am opening this PR as a draft to discuss the tool. Maintainers or contributors would have no overhead as inlang is built on git. No accounts (login with GitHub), no sync, and no pipelines are required. Contributions open a PR.
Would a UI over the translations in this repo be of benefit to the Django-filter community? There are a couple of issues regarding this topic. Translations #1512
or PR #1516
Issue #1510 is still open, although you merged the PR #1515. I guess you can reduce your issue counter and can close this issue :)
You can try it out on my fork and post your feedback under this draft.
https://inlang.com/editor/github.com/jannesblobel/django-filter
You can see a short preview in the video. While translating, I noticed that some translations still need to be included; maybe someone from the community can correct them.
Need to include translation in this Language.
es_AR = Spanish Argentina,
zh_CN = Chinese
The PR is theoretically ready for review.
CleanShot.2023-01-30.at.21.58.22.mp4