-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated packaging to use pyproject.toml and Flit. #1589
Updated packaging to use pyproject.toml and Flit. #1589
Conversation
@carltongibson can I have a workflow run please? |
It's all pyproject.toml these days no? I've been using Flit on other projects, and will likely move to that at some point. |
ded51c8
to
a4c5495
Compare
there you go. The flit build seems broken though:
|
Hmmm OK we were affected by this particularity of flit, I got it fixed. |
8c34957
to
72035f3
Compare
@carltongibson can I have a workflow run please? |
@deronnax Thanks for this. Just so you know, life is pretty full-on right now, so I will likely be a week or so to get to this. Thanks! |
OK. I go in holiday for 2 tweeks next Friday, so I won't bother you too much. Btw, I think it is ready to be merged, but you do you :) |
let's merge :) ? |
Nearly to it @deronnax. Thanks. 🙏 |
Codecov Report
@@ Coverage Diff @@
## main #1589 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 15 15
Lines 1271 1271
=======================================
Hits 1253 1253
Misses 18 18 |
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2c28576
to
b3f2577
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because setup.py is deprecated and setup.cfg is one step toward pyprojects.toml.