Fix DeprecationWarning for pkgutil.find_loader #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `find_loader` function is deprecated in Python 3.12 and slated for removal in Python 3.14. The function is a wrapper around `importlib.util.find_spec`, and returning the `loader` attribute from that call. The code isn't using the loader, and only checking that the import path exists, so we may use the wrapped function directly, instead. fixes: carltongibson#1616
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1623 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 15 15
Lines 1281 1281
=======================================
Hits 1263 1263
Misses 18 18 ☔ View full report in Codecov by Sentry. |
sliverc
added a commit
to sliverc/django-rest-framework-json-api
that referenced
this pull request
Nov 20, 2023
Can be removed once carltongibson/django-filter#1623 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
find_loaderfunction is deprecated in Python 3.12 and slated for removal in Python 3.14. The function is a wrapper aroundimportlib.util.find_spec, and returning theloaderattribute from that call. The code isn't using the loader, and only checking that the import path exists, so we may use the wrapped function directly, instead.fixes: #1616