-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pyproject.toml #289
Conversation
I ran the tests, it does not work on python 3.6, because setuptools on that python version does not support editable installs for projects with only pyproject.toml I see the following options
|
I think, remove the editable install. I see no reason why the editable install would need to be tested, not sure why I added that in the first place. |
This fails on python 3.6 and is a feature provided by setuptools
I found more problems, the short story is, setuptools 59 was just not far enough in the implementation for pyproject.toml. I looked at the stats and run them for march 2024 python 3.6 | 0.35% │ 10,700 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with removing support for Python 3.6.
@TahirJalilov What do you think?
Thank you for your PR! |
Closes #288