Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pyproject.toml #289

Merged
merged 4 commits into from
Apr 27, 2024
Merged

Migrate to pyproject.toml #289

merged 4 commits into from
Apr 27, 2024

Conversation

lovetox
Copy link
Contributor

@lovetox lovetox commented Apr 22, 2024

Closes #288

@lovetox
Copy link
Contributor Author

lovetox commented Apr 23, 2024

I ran the tests, it does not work on python 3.6, because setuptools on that python version does not support editable installs for projects with only pyproject.toml

I see the following options

  • Drop python 3.6 compatibility
  • Disable the editable install test
  • Wait with the move to pyproject.toml

@cvzi
Copy link
Contributor

cvzi commented Apr 23, 2024

I think, remove the editable install. I see no reason why the editable install would need to be tested, not sure why I added that in the first place.

This fails on python 3.6 and is a feature provided by setuptools
@lovetox
Copy link
Contributor Author

lovetox commented Apr 23, 2024

I found more problems, the short story is, setuptools 59 was just not far enough in the implementation for pyproject.toml.
I added a commit to drop python 3.6 compatibility.

I looked at the stats and run them for march 2024

python 3.6 | 0.35% │ 10,700

Copy link
Contributor

@cvzi cvzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with removing support for Python 3.6.

@TahirJalilov What do you think?

emoji/__init__.py Show resolved Hide resolved
@TahirJalilov TahirJalilov merged commit 90f5a46 into carpedm20:master Apr 27, 2024
7 checks passed
@TahirJalilov
Copy link
Collaborator

Thank you for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate project to pyproject.toml
3 participants