-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move type annotations inline #290
Conversation
I need a few days before I have time to look at this in detail. Can you enable and run the github action on your forked repository to test all Python versions? You should be able to run it manually for each branch. It fails on older Python on my machine. It there is no easy fix, maybe we could drop support for end-of-life Python versions. We would need to check how often the package is still used on those versions at the moment (ref #243 ) |
hi, all checks run now trough on all python versions But this is only possible with a new dependency
If we don't want this dependency then our options are
|
We could also use the Match class from |
PR rebased, and code review suggestions squashed |
I added some CI updates
|
Looks good to me. The @TahirJalilov I think you can merge this too, but let's wait with a new release. I will look into solving some of these |
As the typing extension is accepted, i fixed the last thing that we now use the Match object from |
ok @cvzi Thank you! |
This moves all type annotations inline
type: ignore
on some lines because pyright thinks there are errors, this should be checked after this is mergedThis does not mean you need to use pyright as a type checker for this project.
The config section simply allows developers who use pyright to pick up the config.