Lrucache #295
Merged
Lrucache #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move pytest import mode to importlib * move helper functions for tests into utils/testutils.py * replace private `_EMOJI_UNICODE` in tests * add option to pytest to run tests in random order with `pytest --shuffle`
Upgrade to ubuntu 22.04
i.e. get an emoji from a shortcode/:emoji_name:
it is not necessary after all
|
@cvzi Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
type: ignorein core.py and tokenizer.pyutils/testutils.py_EMOJI_UNICODEin testspytest --shufflepypy-3.10to CI tests, we have listed pypy as supported, so we should test it@functools.lru_cacheto reverseEMOJI_DATAwith new functionget_emoji_by_name()Code enhancements suggestions #292get_emoji_unicode_dict(),get_aliases_unicode_dict(),_EMOJI_UNICODEand_ALIASES_UNICODEto testutils. They are not longer needed with the newget_emoji_by_name()function, but they are still used in the testsrelease-45, but there were no changes to any emoji translations