fix: accept readonly arrays in fromFixture's parameters
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
commented
Oct 13, 2021
source/from-fixture.ts
Outdated
Comment on lines
12
to
15
| suggestions?: | ||
| | readonly eslint.SuggestionOutput<TMessageIds>[] | ||
| | null | ||
| | undefined; |
There was a problem hiding this comment.
When typescript-eslint/typescript-eslint#3844 gets in, it could be simply:
Suggested change
| suggestions?: | |
| | readonly eslint.SuggestionOutput<TMessageIds>[] | |
| | null | |
| | undefined; | |
| suggestions: eslint.TestCaseError<TMessageIds>["suggestions"]; |
rafaelss95
force-pushed
the
fix/readonly-array-types
branch
from
a086bfc
to
5605aed
Compare
cartant
pushed a commit
that referenced
this pull request
Oct 17, 2021
* fix: accept readonly arrays in `fromFixture`'s parameters * refactor: remove redundant `undefined`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4.