Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TryEvaluate to support priority allow/deny override #1045

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tangyang9464
Copy link
Member

Main Changes

  1. add TryEvaluate method to replace MergeEffects
    Due to the increasingly complex performance and effects, the MergeEffects method has actually lost its original meaning, and its use in the code does not conform to the original design idea. In order to better support more complex effect types, refer to the implementation of Casbin.NET and add TryEvaluate methods
  2. add PriorityAllow/DenyOverride, SubjectPriorityAllow/DenyOverride effect type

Other Changes

  1. extract the enforce method
  2. Reclass constants

for: #1042

Signed-off-by: tangyang9464 tangyang9464@163.com

@casbin-bot
Copy link
Member

@closetool @sagilio please review

@tangyang9464 tangyang9464 force-pushed the priority2 branch 2 times, most recently from 776d46e to c893ccb Compare July 3, 2022 11:03
Signed-off-by: tangyang9464 <tangyang9464@163.com>
@tangyang9464
Copy link
Member Author

@sagilio Please review if you are free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants