Skip to content

Commit

Permalink
Update definitions.ts
Browse files Browse the repository at this point in the history
I noticed that `updateTypes: ['patch']` only matches if `separateMinorPatch` is set to true.
This comes somewhat unexpected and does not seem to be documented anywhere at the moment, as opposed to the documentation of the `patch` setting, where the docs correctly state `Only applies if separateMinorPatch is set to true`.

Maybe related to renovatebot#2818

But without reading the docs, I would expect `updateTypes: ['patch']` to always match on patch updates (e.g. 1.0.0 to 1.0.1) regardless of the `separateMinorPatch` setting (which is only set if we want separate PRs or branches for patch AND minor updates)
  • Loading branch information
casdevs committed Nov 2, 2020
1 parent cdaf3e9 commit 3dc0aa9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/config/definitions.ts
Expand Up @@ -900,7 +900,7 @@ const options: RenovateOptions[] = [
{
name: 'updateTypes',
description:
'Update types to match against (major, minor, pin, etc). Valid only within `packageRules` object.',
'Update types to match against (major, minor, pin, etc). Valid only within `packageRules` object. `patch` only matches if `separateMinorPatch` is set to true',
type: 'array',
// TODO: add allowedValues
subType: 'string',
Expand Down

0 comments on commit 3dc0aa9

Please sign in to comment.