Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Remove deprecated set-output command #1869

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 24, 2024

The GitHub set-output command is now deprecated which results in numerous warnings like at the bottom of https://github.com/casey/just/actions/runs/7603050227

This pull request replaces the old syntax by using the environment file $GITHUB_OUTPUT as recommended in the deprecation notice.
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands

Related to #1868

These tests are modified:

  • junk_is_other()
  • valid_version_is_release()
  • valid_version_with_trailing_characters_is_other()
  • valid_version_with_lots_of_digits_is_release()

@casey
Copy link
Owner

casey commented Jan 24, 2024

Awesome, great PR! I've been procrastinating dealing with these errors. The output of ref-type is used in release.yaml, so I think that needs to be updated too.

@casey
Copy link
Owner

casey commented Jan 24, 2024

Don't worry about the lint failure, I'll fix that.

@cclauss
Copy link
Contributor Author

cclauss commented Jan 24, 2024

@cclauss cclauss requested a review from casey January 24, 2024 23:27
@casey casey merged commit 827e4e5 into casey:master Jan 24, 2024
12 checks passed
@casey
Copy link
Owner

casey commented Jan 24, 2024

Nice, thank you!

@cclauss cclauss deleted the github_actions_remove_deprecating_set-output_command branch January 24, 2024 23:38
@cclauss
Copy link
Contributor Author

cclauss commented Jan 24, 2024

My pleasure. Just is a cool tool!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants