Disable tab links if unauthorized #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrw
force-pushed
the
adrw.2024-05-09.disabledIfUnauthorizedMenu
branch
2 times, most recently
from
f5c7b71
to
417699c
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
adrw
force-pushed
the
adrw.2024-05-09.disabledIfUnauthorizedMenu
branch
3 times, most recently
from
0f881d5
to
e849cb5
Compare
adrw
changed the title
adrw
force-pushed
the
adrw.2024-05-09.disabledIfUnauthorizedMenu
branch
from
e849cb5
to
3f8f8b2
Compare
adrw
force-pushed
the
adrw.2024-05-09.disabledIfUnauthorizedMenu
branch
from
3f8f8b2
to
c5d0042
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, even if a caller is unauthorized to access a tab, they can click the link in the menu and navigate to it. When they do, they encounter the non-UI Misk standard text
unauthorized. When they try to navigate back, it does not force a full page load due to the Turbo pre-load enhancements on the base links.This PR disables the links (they route to the dashboard home which may have access information) and provides on hover tooltip text to explain why the link is not clickable. This will avoid this hard edge case while preserving the pre-loading benefits of Turbo links for tabs that the caller is authorized to access.