Snapshot output directory should be a task input not output

cashapp · May 15, 2023 · 7c8bd69 · 7c8bd69
1 parent 5a97ceb
commit 7c8bd69
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt b/paparazzi/paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
@@ -179,9 +179,11 @@ class PaparazziPlugin : Plugin<Project> {
         test.inputs.files(nativePlatformFileCollection)
           .withPropertyName("paparazzi.nativePlatform")
           .withPathSensitivity(PathSensitivity.NONE)
+        test.inputs.files(snapshotOutputDir)
+          .withPropertyName("paparazzi.snapshot.output.dir")
+          .withPathSensitivity(PathSensitivity.RELATIVE)
 
         test.outputs.dir(reportOutputDir)
-        test.outputs.dir(snapshotOutputDir)
 
         @Suppress("ObjectLiteralToLambda")
         // why not a lambda?  See: https://docs.gradle.org/7.2/userguide/validation_problems.html#implementation_unknown

diff --git a/...zi/paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt b/...zi/paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
@@ -763,7 +763,7 @@ class PaparazziPluginTest {
     assertThat(resourceFileContents[4]).isEqualTo("intermediates/assets/debug")
     assertThat(resourceFileContents[5]).isEqualTo("app.cash.paparazzi.plugin.test")
     assertThat(resourceFileContents[6]).isEqualTo("src/main/res,src/debug/res")
-    assertThat(resourceFileContents[7]).isEqualTo("caches/transforms-3/6e46d558be9195722df23f983e56c9d0/transformed/external/res")
+    assertThat(resourceFileContents[7]).isEqualTo("caches/transforms-3/0a93740b0d39bc4cff875b0e543c2c2e/transformed/external/res")
   }
 
   @Test
@@ -785,7 +785,7 @@ class PaparazziPluginTest {
     assertThat(resourceFileContents[4]).isEqualTo("intermediates/assets/debug")
     assertThat(resourceFileContents[5]).isEqualTo("app.cash.paparazzi.plugin.test")
     assertThat(resourceFileContents[6]).isEqualTo("src/main/res,src/debug/res")
-    assertThat(resourceFileContents[7]).isEqualTo("caches/transforms-3/6e46d558be9195722df23f983e56c9d0/transformed/external/res")
+    assertThat(resourceFileContents[7]).isEqualTo("caches/transforms-3/0a93740b0d39bc4cff875b0e543c2c2e/transformed/external/res")
   }
 
   @Test

diff --git a/.../src/test/snapshots/images/app.cash.paparazzi.plugin.test_RecordTest_record.png b/.../src/test/snapshots/images/app.cash.paparazzi.plugin.test_RecordTest_record.png