Remove legacy resources/assets loading mechanism #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodbx
force-pushed
the
jrod/2024-01-17/remove-legacy-resources
branch
from
0380f9c
to
54529c3
Compare
JakeWharton
approved these changes
Jan 17, 2024
luis-cortes
approved these changes
Jan 17, 2024
TWiStErRob
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Woohoo, finally we can revisit #1136
Why is there a dependency on the other PR?
paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Show resolved
Hide resolved
jrodbx
force-pushed
the
jrod/2024-01-16/migrate-resources-properties
branch
6 times, most recently
from
c157401
to
47f6a7f
Compare
jrodbx
force-pushed
the
jrod/2024-01-17/remove-legacy-resources
branch
3 times, most recently
from
fe7ccb5
to
611f7ef
Compare
Base automatically changed from
jrod/2024-01-16/migrate-resources-properties
to
master
January 19, 2024 21:07
jrodbx
force-pushed
the
jrod/2024-01-17/remove-legacy-resources
branch
from
611f7ef
to
8c6a889
Compare
To explicitly highlight which properties were going away! |
jrodbx
force-pushed
the
jrod/2024-01-17/remove-legacy-resources
branch
from
8c6a889
to
f16a897
Compare
jrodbx
changed the base branch from
master
to
jrod/2024-01-20/new-resource-variant-caching-bugs
jrodbx
force-pushed
the
jrod/2024-01-20/new-resource-variant-caching-bugs
branch
5 times, most recently
from
47d49ae
to
788f617
Compare
jrodbx
force-pushed
the
jrod/2024-01-17/remove-legacy-resources
branch
from
f16a897
to
97a3ba4
Compare
kevinzheng-ap
approved these changes
Jan 22, 2024
Base automatically changed from
jrod/2024-01-20/new-resource-variant-caching-bugs
to
master
January 22, 2024 12:21
jrodbx
force-pushed
the
jrod/2024-01-17/remove-legacy-resources
branch
from
97a3ba4
to
34cf0ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.