Unify the code to get the path of a golden snapshot #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Righ now at paparazzi there are 3 different implementations to get the path of a golden snapshot. They are equivalent but their implementations are different. That makes them easy to unsync and that if you need that path in other places you need to reimplement it.
This PR fixes that moving all the logic to a single extension funcion and adding tests to avoid regressions (those paths didn't have any test).
The reason of this PR is because it is needed for #902 and #917. I assume that moving this to a separate PR will make it easier to review.