Fixes Issue About Extra Generated Resources Rendering #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinzheng-ap
changed the title
kevinzheng-ap
commented
Mar 14, 2024
| val generateResValuesDirs = project.tasks.withType(GenerateResValues::class.java).filter { it.variantName == variant.name }.map { it.resOutputDir } | ||
| localResourceDirs.relativize(projectDirectory) + generateResValuesDirs.map(projectDirectory::relativize) | ||
| val generateResValuesDirs = project.findTask<GenerateResValues>(variant).map { it.resOutputDir } | ||
| val extraGeneratedResDirs = project.findTask<MapSourceSetPathsTask>(variant).map { it.extraGeneratedResDir.get().map { File(it) } }.flatten() |
There was a problem hiding this comment.
As discussed in #1307 (comment), this is a temp solution to fetch extra generated res folders. It will be changed to new Gradle API after #1136 lands
jrodbx
approved these changes
Mar 15, 2024
paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
kevinzheng-ap
force-pushed
the
kzheng/2024-03-13/issue-1067
branch
from
0d18ac0
to
b7f4d39
Compare
…n new resource loading mechanism
kevinzheng-ap
force-pushed
the
kzheng/2024-03-13/issue-1067
branch
from
b7f4d39
to
b46630d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fix to #1067 to handle extra generated res folders, which are set via
BaseVariant.registerGeneratedResFolders