Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boolean Flag to decide if image should be original size or not #1382

Merged
merged 13 commits into from May 16, 2024

Conversation

emuguy1
Copy link
Contributor

@emuguy1 emuguy1 commented Apr 16, 2024

Inspired by different other comments, Issues and another Pull Request by @sdoward #543, I tried to add a more simpler solution to the problem I and other developers are facing.
As I want to use the created Screenshots to also upload it to the PlayStore and need full Res Images for that the current limit is blocking me from using the images.

Therefore I added an optional boolean flag 'useDeviceResolution', that when set to true, lets the resulting image be the deviceConfigs scale.

In the default case the image still gets downscaled to decrease file size.

I would really appreciate a feedback and if possible a fast inclution in the project, as I really want/need this feature.

…ng image be the deviceConfigs scale.

In the default case the image still gets downscaled to decrease file size
@emuguy1
Copy link
Contributor Author

emuguy1 commented May 7, 2024

@swankjesse Is there any update on when this can be included in an release? What would be the process to include something like this. Is there something I can help to get this issue resolved?

@mehrmann
Copy link

We're facing the same issue, would want this to be merged so we can choose to have high resolution screenshots.

@jrodbx
Copy link
Collaborator

jrodbx commented May 13, 2024

@emuguy1 I'm ambivalent about adding this as it will likely be rewritten and break in the future; that being said, it seems like a simple enough thing to include now. Mind adding a test that varies the boolean value using TestParameterInjector (see paparazzi-gradle-plugin/src/test/projects/locale-qualifier for an example)?

@emuguy1
Copy link
Contributor Author

emuguy1 commented May 15, 2024

@swankjesse @jrodbx can maybe one of you take a look at this. It fails with a gradle build error saying it cant find the guava-fix.gradle

Build file '/Users/runner/work/paparazzi/paparazzi/paparazzi-gradle-plugin/src/test/projects/device-resolution/build.gradle' line: 28

* What went wrong:
A problem occurred evaluating root project 'device-resolution'.
> Could not read script '/Users/runner/work/paparazzi/paparazzi/paparazzi-gradle-plugin/src/test/projects/guava-fix.gradle' as it does not exist.

I did find the error with the image difference. But this one I cant work out. I definitely see the file, the build gradle is the same as in the other projects and there it works.

Thanks for the help in advance.

@TWiStErRob
Copy link
Contributor

Update from main and remove the apply:
d206649

@emuguy1
Copy link
Contributor Author

emuguy1 commented May 16, 2024

it works!!!!!! nice thanks a lot.

@jrodbx jrodbx merged commit 18e7196 into cashapp:master May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants