New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boolean Flag to decide if image should be original size or not #1382
Conversation
…ng image be the deviceConfigs scale. In the default case the image still gets downscaled to decrease file size
@swankjesse Is there any update on when this can be included in an release? What would be the process to include something like this. Is there something I can help to get this issue resolved? |
We're facing the same issue, would want this to be merged so we can choose to have high resolution screenshots. |
@emuguy1 I'm ambivalent about adding this as it will likely be rewritten and break in the future; that being said, it seems like a simple enough thing to include now. Mind adding a test that varies the boolean value using TestParameterInjector (see |
paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
Outdated
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
Outdated
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
Outdated
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/test/projects/device-resolution-qualifier/build.gradle
Outdated
Show resolved
Hide resolved
...ice-resolution-qualifier/src/test/java/app/cash/paparazzi/plugin/test/LocaleQualifierTest.kt
Outdated
Show resolved
Hide resolved
...ice-resolution-qualifier/src/test/java/app/cash/paparazzi/plugin/test/LocaleQualifierTest.kt
Outdated
Show resolved
Hide resolved
sample/src/test/java/app/cash/paparazzi/sample/TestParameterInjectorTest.kt
Outdated
Show resolved
Hide resolved
...ugin/src/test/projects/device-resolution-qualifier/src/test/resources/resolution_default.png
Outdated
Show resolved
Hide resolved
...ugin/src/test/projects/device-resolution-qualifier/src/test/resources/resolution_default.png
Outdated
Show resolved
Hide resolved
@swankjesse @jrodbx can maybe one of you take a look at this. It fails with a gradle build error saying it cant find the guava-fix.gradle
I did find the error with the image difference. But this one I cant work out. I definitely see the file, the build gradle is the same as in the other projects and there it works. Thanks for the help in advance. |
Update from main and remove the apply: |
paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
Outdated
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/test/projects/device-resolution/build.gradle
Outdated
Show resolved
Hide resolved
it works!!!!!! nice thanks a lot. |
Inspired by different other comments, Issues and another Pull Request by @sdoward #543, I tried to add a more simpler solution to the problem I and other developers are facing.
As I want to use the created Screenshots to also upload it to the PlayStore and need full Res Images for that the current limit is blocking me from using the images.
Therefore I added an optional boolean flag 'useDeviceResolution', that when set to true, lets the resulting image be the deviceConfigs scale.
In the default case the image still gets downscaled to decrease file size.
I would really appreciate a feedback and if possible a fast inclution in the project, as I really want/need this feature.