Handle date/time conversion in runtime #258
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to handle converting to ICU Calendar
drewhamilton
commented
Nov 3, 2023
plugin/src/main/java/app/cash/paraphrase/plugin/ResourceWriter.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+34
to
+38
| private val Iso8601Locale by lazy(LazyThreadSafetyMode.NONE) { | ||
| ULocale.Builder() | ||
| .setExtension('u', "ca-iso8601") | ||
| .build() | ||
| } |
There was a problem hiding this comment.
Since AndroidDateTimeConverter is an object, this ULocale instantiation was happening immediately when FormattedResources was accessed, causing the JVM test to (still) crash. Loading it lazily avoids this.
sample/library/src/test/kotlin/app/cash/paraphrase/sample/library/JvmDateTimeConverter.kt
Show resolved
Hide resolved
This prevents the ULocale from being instantiated at class-loading time, which would crash JVM tests due to the missing Android implementation.
drewhamilton
force-pushed
the
drew/handle-date-time-conversion-in-runtime
branch
from
7fa0ec6
to
83c9523
Compare
JakeWharton
approved these changes
Nov 4, 2023
plugin/src/main/java/app/cash/paraphrase/plugin/ResourceWriter.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+35
to
+36
| @Before fun substituteDateTimeConverter() { | ||
| FormattedResources.dateTimeConverter = JvmDateTimeConverter |
There was a problem hiding this comment.
Yep. Nothing better came to mind quickly but I can stew on it a bit longer.
sample/library/src/test/kotlin/app/cash/paraphrase/sample/library/JvmDateTimeConverter.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230.
This implements the first solution I proposed in #230. I'm not overly attached to this approach, just wanted to prove it out.
This pulls all
android.icuimports out of generated code and into the runtime, allowing substitution of non-Android ICU dependencies in JVM unit tests.Generated code now uses a generic
DateTimeConverterinterface to format date/time parameters. The defaultAndroidDateTimeConverterimplementation instantiatesandroid.icu.util.Calendars. JVM tests can substitute aJvmDateTimeConverterinto theirFormattedResourcesobject to instantiatecom.ibm.icu.util.Calendars, avoiding the need for Robolectric to format date/time strings.