New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Azul JDK for toolchains #3857
Conversation
I spoke too soon. Azul isn't really supported yet. In any case, trying to build SQLDelight on an Apple Silicon mac current doesn't work. |
You need to add https://github.com/gradle/foojay-toolchains for this to work. However, you may run into a bug so it's best to wait for Gradle 7.6.1 or 8.0 before landing it. |
What do you mean by building sqldelight on m1? I am using m1 too and it works well 🤔 |
I'm guessing you have a JDK 8 installed locally that Gradle is using? My oldest JDK is 11 so Gradle is trying to download an Adoptium build for JDK 8, and there is none for M1. |
Oh, I checked it and yeah, you are right. I installed azul jdk 8 locally. |
Use this to install it manually (and automatically keep it up-to-date) for now: https://github.com/mdogan/homebrew-zulu |
Added the foojay plugin, and sure enough it's blocked by an issue that was fixed in 7.6.1/8.0. I'll leave this open as a draft PR until we're able to upgrade gradle. |
I thought we could upgrade to the new release of Gradle 8.0 but the build fails due to https://youtrack.jetbrains.com/issue/KT-55751/MPP-Gradle-Consumable-configurations-must-have-unique-attributes |
58a4416
to
ed3e020
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a lot of these!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is time to use convention plugins too ;)
Very nice! |
Gradle JVM toolchains use Adoptium by default which doesn't have a JDK 8 builds for Apple Silicon. Azul does!