New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sorting dependency source folders #4334
base: master
Are you sure you want to change the base?
Conversation
I think this is for determinism with Gradle. Someone commented recently that a non-determism was fixed with 2.0. |
I don't get it, do you have more details? Background of this PR: I want to fix #3952 with native Gradle dependencies (and configurations) and the list prevents this/makes the implementation more complicated. |
yep, what jake said |
Hm, the linked commit and issue is about the generated Kotlin code: 4723e6f I just talk about passing the files to SqlCoreEnvironment. |
aight, gonna leave to after 2.0 since it is a binary incompatible change for the gradle tooling api |
We don't accept breaking api changes from 2.0.0-rc02 to 2.0.0 but from 2.0.0 to 2.1.0? |
as long as its not the runtime api im fine |
only bug fixes from now on, i need to get this release out |
Any plans to review/merge it? |
What is the reason to sort the files?
After digging, it is only used for testing.