Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hook #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add hook #19

wants to merge 2 commits into from

Conversation

enricolucia
Copy link
Contributor

No description provided.

@enricolucia
Copy link
Contributor Author

Just need to be cleaned up a bit.
But it injects directly on uiRouter as well as ngRoute modules.

Let me know any thoughts about it.

@alexcastillo
Copy link
Member

@enricolucia Thanks for the PR!
I'll be testing it sometime this week.

@enricolucia
Copy link
Contributor Author

@AlexanderCastillo Thanks to you!
Just need to have a rethink about injecting resolves on uiRouter as I would like the have the them resolved before $stateChangeSuccess like ngRouter implementation does.

I will try to come up with something for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@enricolucia @alexcastillo