Remove obsolete code in Castle.Facilities.Logging
#636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2022
Closed
Jevonius
force-pushed
the
remove-obsolete-logging
branch
from
657a57a
to
7bf729f
Compare
jonorossi
approved these changes
Dec 2, 2022
jonorossi
reviewed
Dec 2, 2022
src/Castle.Facilities.AspNet.SystemWeb.Tests/Castle.Facilities.AspNet.SystemWeb.Tests.csproj
Show resolved
Hide resolved
jonorossi
reviewed
Dec 2, 2022
| @@ -12,6 +12,7 @@ Bugfixes: | |||
|
|
|||
| Breaking Changes: | |||
| - Microsoft.Extensions.Hosting related methods have been removed from the Castle.Windsor.Extensions.DependencyInjection package to the Castle.Windsor.Extensions.Hosting package (@ikkentim, #625, #628) | |||
| - Obsolete components in Castle.Facilities.Logging have been removed. Extensions methods for built-in logging factories have been added. (@Jevonius, #616) | |||
There was a problem hiding this comment.
Could you list out the public APIs that have been removed like we do in Castle Core (https://github.com/castleproject/Core/blob/master/CHANGELOG.md#440-2019-04-05) so it makes it clear to upgraders and to enable search. You don't need every enum member, just the enum type name.
There was a problem hiding this comment.
Here are the removed classes and methods. Is anything else needed to merge this and create a release. I am happy to help get this out the door.
- Removed class Castle.Facilities.Logging.LoggerImplementation
- Removed constructor Castle.Facilities.Logging.LoggingFacility(LoggerImplementation loggingApi)
- Removed constructor Castle.Facilities.Logging.LoggingFacility(LoggerImplementation loggingApi, string configFile)
- Removed constructor Castle.Facilities.Logging.LoggingFacility(string customLoggerFactory, string configFile)
- Removed method Castle.Facilities.Logging.LoggingFacility.LogUsing(LoggerImplementation loggingApi)
- Removed method Castle.Facilities.Logging.LoggingFacility.UseLog4Net()
- Removed method Castle.Facilities.Logging.LoggingFacility.UseLog4Net(string configFile)
- Removed method Castle.Facilities.Logging.LoggingFacility.UseNLog()
- Removed method Castle.Facilities.Logging.LoggingFacility.UseNLog(string configFile)
…on symbols as they're no longer required The tests now work across all target frameworks.
This works around an issue with NUnit3TestAdapter private referencing this version, stopping assembly binding redirects, and Windsor struggling to call `GetExportedTypes` as a result.
Jevonius
force-pushed
the
remove-obsolete-logging
branch
from
0e494b3
to
f021840
Compare
|
I've re-based this, and build now passing again. Still need to update the docs regarding deprecated APIs. |
|
@jonorossi is there something preventing us from moving forward here as suggested by @Regenhardt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work to resolve #616; it's built off the #630 branch, so I anticipate rebasing this branch once that's merged down. There will be more noise in this PR until then.