feat(content): Set 3D field of vision to True by default
#4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: anothersimulacrum <42699974+anothersimulacrum@users.noreply.github.com>
Co-Authored-By: anothersimulacrum <42699974+anothersimulacrum@users.noreply.github.com>
Yeah about that, we already made z-level behavior mandatory, 3D vision is a different thing entirely. |
|
anothersimulacrum should be removed from author. i had left them in from the last pull request i started |
chaosvolt
approved these changes
May 13, 2024
There was a problem hiding this comment.
Bit belatedly, I'm not sure if there's any major bugs we're missing with the feature, but this is only setting it on as default rather than making it mandatory, so it's probably alright. That said, I'll leave this for @Coolthulhu or @scarf005 to advise on this just in case before merging.
scarf005
approved these changes
May 13, 2024
|
No major bugs, but major lags with it turned on. That's gon' be a no from me, dawg. z-Levels, yes, 3D-vision, no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Describe the solution
changes the
3D field of visionvalue to true by default, changes some wordingDescribe alternatives you've considered
Testing
Additional context
Checklist