Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): updates to cleaning supply and bathroom itemgroups #4632

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented May 11, 2024

Purpose of change

Finally tackling another big source of jank in Specific Use Storage itemgroups, which led me to clean up (heh) a few related itemgroups along the way for good measure.

Describe the solution

  1. Defined a few new itemgroups: supplies_household_cleaning for soap and bleach and such, tools_cleaning_common for general tools that go in janitor's closets and such, tools_cleaning_small for general scrubbing items (also nested in tools_cleaning_common), and clothing_cleaning for the typical PPE. These are intended to be used in several cleaning-related itemgroups to make things a bit neater.
  2. Merged some spawns in the cleaning itemgroup to use the new itemngroups.
  3. Included some chance of tools_cleaning_small in behindcounter, dollar_kitchen, livingroom, kitchen, replacing the [Little Sponge] (and occasional brush or rag) in those itemgroups.
  4. Also merged cleaningsupplies in kitchen itemgroup.
  5. Reworked SUS_kitchen_sink to have a smaller number of calls to supplies_household_cleaning and tools_cleaning_small instead of its highly specific bunch of stuff, and added a bonus chance of seeing some clothing_cleaning.
  6. Overhauled the fabled SUS_bathroom_cabinet to use a better variety of items. Makes use of supplies_household_cleaning, tools_cleaning_common, and drugs_heal_simple.
  7. Added hydrogen peroxide to drugs_heal_simple since it was an item removed from explicit spawns in SUS_bathroom_cabinet that was notably missing from that group.
  8. Updated SUS_janitors_closet to make use of supplies_household_cleaning, tools_cleaning_common, and clothing_cleaning.
  9. Misc: set it so basement and domestic palettes don't spam several potential spawns of SUS_toilet, and reworked it to spawn weight scales way less often but also reliably spawn paper in lieu of the old obsoleted toilet paper item.

Describe alternatives you've considered

Screm

Testing

  1. Checked affected files for syntax and lint errors.
  2. Grabbed some itemgroup test results of the two notable SUS groups before and after changes.
Screenshots:

SUS_bathroom_cabinet, before:
cabinet before

SUS_bathroom_cabinet, after:
cabinet after

SUS_janitors_closet, before:
closet before

SUS_janitors_closet, after:
closet after

Lists are overall a lot longer due to the wider variety of stuff that can spawn and especially charges variation, but total amount of stuff seems to correctly be lower.

Test images also predate Viss' suggestion of having plastic bags spawn in cleaning tools.

Additional context

Checklist

@github-actions github-actions bot added the data PRs related to datas. Won't crash game (probably) label May 11, 2024
@chaosvolt chaosvolt merged commit d15036a into cataclysmbnteam:main May 13, 2024
10 checks passed
@chaosvolt chaosvolt deleted the makin-sus-less-sus-part-i-forgot-blyat branch May 13, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants