feat(balance): updates to cleaning supply and bathroom itemgroups #4632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Finally tackling another big source of jank in Specific Use Storage itemgroups, which led me to clean up (heh) a few related itemgroups along the way for good measure.
Describe the solution
supplies_household_cleaning
for soap and bleach and such,tools_cleaning_common
for general tools that go in janitor's closets and such,tools_cleaning_small
for general scrubbing items (also nested intools_cleaning_common
), andclothing_cleaning
for the typical PPE. These are intended to be used in several cleaning-related itemgroups to make things a bit neater.cleaning
itemgroup to use the new itemngroups.tools_cleaning_small
inbehindcounter
,dollar_kitchen
,livingroom
,kitchen
, replacing the [Little Sponge] (and occasional brush or rag) in those itemgroups.kitchen
itemgroup.SUS_kitchen_sink
to have a smaller number of calls tosupplies_household_cleaning
andtools_cleaning_small
instead of its highly specific bunch of stuff, and added a bonus chance of seeing someclothing_cleaning
.SUS_bathroom_cabinet
to use a better variety of items. Makes use ofsupplies_household_cleaning
,tools_cleaning_common
, anddrugs_heal_simple
.drugs_heal_simple
since it was an item removed from explicit spawns inSUS_bathroom_cabinet
that was notably missing from that group.SUS_janitors_closet
to make use ofsupplies_household_cleaning
,tools_cleaning_common
, andclothing_cleaning
.SUS_toilet
, and reworked it to spawn weight scales way less often but also reliably spawn paper in lieu of the old obsoleted toilet paper item.Describe alternatives you've considered
Screm
Testing
Screenshots:
SUS_bathroom_cabinet
, before:SUS_bathroom_cabinet
, after:SUS_janitors_closet
, before:SUS_janitors_closet
, after:Lists are overall a lot longer due to the wider variety of stuff that can spawn and especially charges variation, but total amount of stuff seems to correctly be lower.
Test images also predate Viss' suggestion of having plastic bags spawn in cleaning tools.
Additional context
Checklist